Closed (fixed)
Project:
CiviCRM Entity
Version:
7.x-2.x-dev
Component:
CiviCRM Entity Actions
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
25 Sep 2016 at 21:12 UTC
Updated:
25 Feb 2018 at 03:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
markusa commentedDo you have a proposed alternative?
Comment #3
markusa commented@xuridaemon
Have you had any ideas, or had any time to spend on this issue?
Comment #4
markusa commentedComment #5
xurizaemonThe information you might need though is that drupal_goto() terminates the request (see drupal_goto - we make sure none of the code below the drupal_goto() call gets executed upon redirection).
If this function is used in a Rules Action, then the UI will permit people to add actions following the action that contains a drupal_goto, but those actions will never be executed. Neither will any other behaviour attached to the page at a later point than the rule, which means this implementation permits a range of unexpected outcomes.
Probably more robust would be to use rules_action_drupal_goto() in place of drupal_goto(), as it contains code to handle this specific concern.
PR @ https://github.com/eileenmcnaughton/civicrm_entity/pull/129
Untested :)
Comment #6
xurizaemonPatch @ https://github.com/eileenmcnaughton/civicrm_entity/pull/129.patch updated, forgot to upload here!
This addresses the Rules dependency in previous approach by wrapping the Rules function in a wrapper which will use drupal_goto in the event that Rules isn't available.
Comment #7
xurizaemonComment #9
markusa commented