On every PHPCS run, I get this message:
DEPRECATED: Passing an array of values to a property using a comma-separated string
was deprecated in PHP_CodeSniffer 3.3.0. Support will be removed in PHPCS 4.0.0.
The deprecated syntax was used for property "include"
for sniff "SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalFunctions".
Pass array values via <element [key="..." ]value="..."> nodes instead.
Splitting the long list of PHP functions we want globally addressed (e.g. \array_map()) addresses the deprecations.
It will also make it easier to read future additions to the list
N/A
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
wim leersYep, that's noise I've been wanting to eliminate for a while. Thanks for filing this issue!
Comment #4
tim.plunkettComment #5
naveenapj commentedComment #6
naveenapj commentedI have tested and validated this locally on PHP 8.4 and Drupal 11.
Testing Process:
On the 1.x branch, I successfully reproduced the hard error: ERROR: Passing an array of values to a property using a comma-separated string is no longer supported.
Applied MR !1094.
Confirmed the phpcs.xml file now uses the valid array syntax for the SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalFunctions rule.
Ran phpcs again; the error is resolved, and the sniffs are parsed and executed correctly.
The code change is correct and follows the standard required by modern PHPCS versions. Setting to RTBC.
Comment #7
naveenapj commentedComment #8
naveenapj commentedComment #9
wim leersThanks!