Overview

This regression was introduced in #3586655: CI: do not run E2E tests when zero JS or PHP is modified; reorganize `rules`.

https://git.drupalcode.org/project/canvas/-/merge_requests/1003 was merged without running phpunit.
No problem in this case, but it could be.

We should ensure phpunit jobs run when canvas.install changes.

Proposed resolution

Fix gitlabci so:

  • Changes to canvas.install are detected and run phpunit
  • Changes to submodules *.module, .install and *.post_updates.php are detected and run phpunit. the existing modules/**/* rule already handles this

User interface changes

None.

Issue fork canvas-3588685

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Title: CI: *.module changes skipping phpunit » CI: *.install changes skipping phpunit
Issue summary: View changes

penyaskito opened merge request !1064

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue summary: View changes
Status: Active » Needs review
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: CI: *.install changes skipping phpunit » CI: *.install changes should trigger PHPUnit CI jobs
Assigned: Unassigned » wim leers

Good call!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: CI: *.install changes should trigger PHPUnit CI jobs » CI: #3586655 failed to configure canvas.install changes to trigger PHPUnit CI jobs
Assigned: wim leers » Unassigned
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
Related issues: +#3586655: CI: do not run E2E tests when zero JS or PHP is modified; reorganize `rules`
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Category: Task » Bug report
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.