Overview

Currently when returning content entities such as Page from auto-saves/pending endpoint cache tags are missing. Let's fix that.

Proposed resolution

Add enforceIsNew(FALSE) call when creating new entity in AutoSaveManager::getAllAutoSaveList() and update tests accordingly.

User interface changes

None.

Issue fork canvas-3588546

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

f.mazeikis created an issue. See original summary.

f.mazeikis opened merge request !1057

f.mazeikis’s picture

f.mazeikis commented
Assigned: f.mazeikis » wim leers
Status: Active » Needs review

Ready for review

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +D8 cacheability

Zero remarks! 🤩

Only was missing an explanation for why adding that one method call to fix everything is correct. Added that: https://git.drupalcode.org/project/canvas/-/merge_requests/1057#note_822341.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Internal HTTP API » Auto-save

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.