Disruptions in the past ~30 days
This previously used to be rare. Each of these bring nice refinements, but they're not worth the disruption for in-progress MRs.
Adopt a strategy similar to #3462742: CI: use a snapshot of core's phpcs rules as changes in Drupal core will break MRs with limited benefit to module development.
Differences:
None.
CI impact: see screenshots in https://git.drupalcode.org/project/canvas/-/merge_requests/1004
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
wim leersReady for final review. Screenshots of it in action in the MR description.
While working on this, I realized it's also absurdly wasteful to run the existing
phpcs-rules-match-drupal-11CI job plus the newphpstan-is-up-to-dateCI job on every commit 🙈😅Once every 24 hours is more than enough.
Comment #4
wim leersComment #6
wim leersComment #9
longwaveWhy use messy curl/jq when Composer can just do this for us?
Comment #11
longwaveOr, just ship a lockfile, which is what we've partially reinvented here.
Comment #12
wim leersThat was what I wanted to do first. But composer does not allow (well, respect) lockfiles in dependencies. It only respects it at the root.
Fair. For something like this, I just don't care, because it does not matter. This is just meant to support us developers of Canvas. It doesn't run in production, and it could be refined in whichever way we want.
(PHCS rules, PHPStan rules, CI scripts are the only place where I will tolerate AI slop. I did acknowledge explicitly in the commits that this was AI-generated! 😇)
Will test your MR and merge if confirmed to work :)
Comment #14
wim leersThanks, your improvement is now in! 👍