Needs review
Project:
Drupal Canvas
Version:
1.x-dev
Component:
Component sources
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
23 Apr 2026 at 12:40 UTC
Updated:
18 May 2026 at 04:54 UTC
Jump to comment: Most recent
Overview
Discovered at https://git.drupalcode.org/project/canvas/-/merge_requests/882#note_760120
For the component instance form of SDCs and code components, we need to know the label.
Currently, the logic for that is hardcoded in \Drupal\canvas\Plugin\Canvas\ComponentSource\GeneratedFieldExplicitInputUxComponentSourceBase::buildComponentInstanceForm().
Which means it's not available for translation.
Proposed resolution
- Add
ComponentSourceInterface::getLabelForExplicitInput(). - Refactor
GeneratedFieldExplicitInputUxComponentSourceBase::buildComponentInstanceForm()to use it.
(Similar to ::getOptionsForExplicitInputEnumProp(), and clearly complementary to ::getExplicitInput()).
User interface changes
None.
Issue fork canvas-3586490
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
wim leersTrying to get this simple one knocked out by AI while I work on something else.
Comment #4
wim leersNow should have failures for some of the component sources, but is well on its way.
WDYT about the direction, @tedbow?
Comment #5
wim leersComment #7
wim leersFor the record: the pretty crappy initial implementation AI did cost $10.367. It used 48 Opus 4.6 requests ($5.79), 323 Haiku 4.5 requests ($4.58). The result is poor.
Comment #8
wim leersComment #9
wim leersOne suggestion left for @tedbow to hopefully agree with — should be an easy merge 🤞
Comment #10
rakhimandhania commented