While working on #3582478: Symmetrically translatable config-defined component trees, STEP 2: change config schema type for `inputs` to allow translating via core's Config Translation UI for ContentTemplates & PageRegions, I ended up needing to investigate where and whether there are differences between the 3 Canvas config entity types storing component trees.
This was made more difficult to assess because the same logic was duplicated in three places.
Remove the duplication; move as much out of ContentTemplate|PageRegion|Pattern into ComponentTreeConfigEntityBase as possible.
None.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
wim leersBlocks #3586216: Follow-up for #3545236: move triplicated logic into `ComponentTreeConfigEntityBase`'s !898.
Comment #4
wim leersThis simplifies the update paths for both #3586216: Follow-up for #3545236: move triplicated logic into `ComponentTreeConfigEntityBase` and #3582464: [PP-2] Symmetrically translatable config-defined component trees, STEP 3: adjust sequence keys to avoid translations breaking when component instances are moved.
Comment #5
penyaskitoI'd feel better knowing what's the reason for the different order of calls predating this refactor.
Comment #6
wim leersComment #7
wim leersThanks, @penyaskito!
Comment #9
wim leers