Overview

:pray: Let's use the `FQCN::class` wherever we can. Reduces magic, makes it easier to navigate & understand these tests.

— yours truly at https://git.drupalcode.org/project/canvas/-/merge_requests/651#note_727491

Proposed resolution

Automate this feedback.

User interface changes

None.

Issue fork canvas-3581133

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

wim leers created an issue. See original summary.

wim leers opened merge request !797

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Odd, seems d.o is not showing the associated MR: https://git.drupalcode.org/project/canvas/-/merge_requests/797

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Issue tags: +AI-accelerated, +Novice, +Chicago2026

This found 66 errors. That makes for a great Novice task, great DrupalCon timing 😄

gurnoor kaur made their first commit to this issue’s fork.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » wim leers
Status: Active » Needs review

Nice, thank you @gurnoor kaur — looks like you addressed 100% of the PHPStan violations, but in doing so caused a bunch of tests to fail. I'll take a look.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Needs work

The tests are failing because the premise of this issue is kinda wrong. There are some services -- like plugin.manager.field.widget -- which don't have a class or interface alias we can use.