I know the memcached (not memcache) is still considered alpha quality, but I thought I would give it a try on a testing site I have to give feedback . I'm using pressflow 6, maybe that's an issue. Here are the warnings.

warning: Memcached::add() expects at most 3 parameters, 4 given in /usr/local/www/pressflow-6/sites/all/modules/cacherouter/engines/memcached.php on line 192.
warning: Memcached::set() expects at most 3 parameters, 4 given in /usr/local/www/pressflow-6/sites/all/modules/cacherouter/engines/memcached.php on line 92.

My libmemcached version is 0.37 and here is my cache router configuration.

$conf['cache_inc'] = './sites/all/modules/cacherouter/cacherouter.inc';
$conf['cacherouter'] = array(
  'default' => array(
    'engine' => 'memcached',
    'servers' => array('127.0.0.1:11211'),
    'shared' => TRUE,
    'prefix' => 'prod',
    'static' => FALSE,
    'fast_cache' => TRUE,
  ),
);

Let me know if I can provide any more info or test anything. Thanks!

CommentFileSizeAuthor
#2 710630_memcached_compression.patch4.28 KBandypost

Comments

dizarb’s picture

I guess Memcached::set and add don't support compression http://us.php.net/manual/en/memcached.add.php . I commented those bits out of the out of memcached.php and it seems to work now.

andypost’s picture

Status: Active » Needs review
StatusFileSize
new4.28 KB

Yes, this is a bug. Please test this code, going to commit to all branches.

Compression setting changed by http://us.php.net/manual/en/memcached.setoption.php

I see no reason with & new

dizarb’s picture

That patch applied cleanly, and everything looks good; no more warnings. Thanks!

andypost’s picture

Status: Needs review » Fixed

Suppose fixed for all branches

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.