Closed (fixed)
Project:
Cache Control
Version:
7.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Jun 2012 at 14:38 UTC
Updated:
8 Jun 2012 at 15:20 UTC
Jump to comment: Most recent file
Patch incoming...
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | clean_up_js-1612978-1.patch | 7.05 KB | oxyc |
Comments
Comment #1
oxyc commentedThe following patch contains some code convention fixes both Drupal and JS specific.
Some fixes.
* Pass Drupal.settings to Drupal.beaviors[b].attach, some code rely on this and might break (e.g. ajax.js)
* Declare all variables not to pollute global scope
* Make sure iteration is only done on objects own properties.
* Fix tabs, missing semicolon and spaces around + operator according to Drupal guidelines.
Thanks for a great module,
www.snellman.fi is now using it.
Comment #2
Janne Salo commentedSeems to work nicely. Committed the patch to the latest dev release. Thanks for the contribution!
(Edit: contribution now also correctly credited to oxyc)