Patch incoming...

CommentFileSizeAuthor
#1 clean_up_js-1612978-1.patch7.05 KBoxyc

Comments

oxyc’s picture

Status: Active » Needs review
StatusFileSize
new7.05 KB

The following patch contains some code convention fixes both Drupal and JS specific.

Some fixes.
* Pass Drupal.settings to Drupal.beaviors[b].attach, some code rely on this and might break (e.g. ajax.js)
* Declare all variables not to pollute global scope
* Make sure iteration is only done on objects own properties.
* Fix tabs, missing semicolon and spaces around + operator according to Drupal guidelines.

Thanks for a great module,
www.snellman.fi is now using it.

Janne Salo’s picture

Status: Needs review » Closed (fixed)

Seems to work nicely. Committed the patch to the latest dev release. Thanks for the contribution!

(Edit: contribution now also correctly credited to oxyc)