modules/contrib/bynder/bynder.libraries.yml

The 'formatter' library is depending on a deprecated library. The "core/jquery.ui.tooltip" asset library is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0.
See https://www.drupal.org/node/3067969

CommentFileSizeAuthor
jqueryui-tooltip-3126557-1.patch790 bytesphoang

Comments

phoang created an issue. See original summary.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Can we make this an optional/suggests dependency and only show this formatter if the module is enabled? I'm not sure how tightly it is tied to it so it may not be possible, it's just good to avoid enforcing dependencies on everyone when everyone may not need it.

mbovan’s picture

mbovan commented

We're including this change in #3126557: Drupal 9 readiness as part of the Drupal 9 compatibility issue.

Regarding #2, I see that the tooltip dependency is used in the standard BynderFormatter to display the usage tooltip information.

However, as there is a @todo about usage API not yet being implemented, we could add jquery_ui_tooltip/tooltip as an optional dependency and depending if the module is enabled show the current usage overlay icon. Thoughts?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Move library jquery.ui.tooltip to jquery_ui_tooltip contrib module » Make the jquery_ui_tooltip contrib module dependency optional
Status: Needs review » Needs work

The other issue did the required conversion, we could use this issue to make it optional.

phoang’s picture

phoang commented
Status: Needs work » Fixed

Patched has been ported. I saw the updates on 3.x and 4.x branch now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.