Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi there,
love the module, but I had some issues grocking where the menu entries were and what is needed to enable this module.
See #1.
Comment | File | Size | Author |
---|---|---|---|
#8 | 1734604-8.patch | 10.84 KB | Kiphaas7 |
#7 | 1734604-6.patch | 10.36 KB | Kiphaas7 |
#3 | patch_commit_1452c1f6ca2a.patch | 10.48 KB | Kiphaas7 |
#1 | patch_commit_766b3ec10921.patch | 10.46 KB | Kiphaas7 |
Comments
Comment #1
Kiphaas7 CreditAttribution: Kiphaas7 commentedAttached patch tries to:
Pretty straightforward patch, though looking forward to any critique on it!
Comment #2
nagba CreditAttribution: nagba commentedThanks, I will take a look at it in the coming days. Better explanation is always welcomed, a fresh set of eyes helps a lot. :)
Comment #3
Kiphaas7 CreditAttribution: Kiphaas7 commentedActually missed a t() call in an addition, updated patch.
Glad to be of any help :).
Comment #4
Kiphaas7 CreditAttribution: Kiphaas7 commentedBy the way: if the patch is too big to review at once, I actually made all the changes in my sandbox:
http://drupal.org/node/1732740/commits
Separates the above patch in 5 commits.
Comment #5
Kiphaas7 CreditAttribution: Kiphaas7 commented+ '!aggregate' => l(t('aggregate CSS and/or JS files'), 'admin/config/development/performance', array('attributes' => array('title' => t('Enable or disable page caching for anonymous users and set CSS and JS bandwidth optimization options.')))),
Has a trailing whitespace :/. Will fix later today.
Comment #7
Kiphaas7 CreditAttribution: Kiphaas7 commentedComment #8
Kiphaas7 CreditAttribution: Kiphaas7 commentedThis is starting to look like spamming, but I actually honestly forgot to update the .info file...
Comment #9
nagba CreditAttribution: nagba commentedlooks good to me
Comment #10
nagba CreditAttribution: nagba commentedI've commited your code, hopefully soon the dev release will update itself and i'll be able to create a new prod release as well.
Comment #11
Kiphaas7 CreditAttribution: Kiphaas7 commentedthanks!
Comment #12
nagba CreditAttribution: nagba commentedClosing issue as the code is now on both dev and stable releases.
Comment #12.0
nagba CreditAttribution: nagba commentedclarify OP