Problem/Motivation

Part of #3175327: [meta] Integrate with UI Patterns module.

Currently in Bulma Components we use the component_string schema type for a tag field:

  tag:
    label: 'The HTML tag to use for the wrapper element'
    nullable: true
    type: component_string
    default: 'div'

Per integration with UI Patterns Settings, a tag would be considered a setting rather than a field.

Proposed resolution

Use the tag type.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3176308-2.patch480 bytesPooja Ganjage

Comments

nedjo created an issue. See original summary.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3176308-2.patch480 bytes

Hi,

I am creating a patch for this issue.

Please review the patch.

Let me know for any suggestions.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Project: Component Schema » Bulma Components
Assigned: Unassigned » nedjo
Issue summary: View changes
Status: Needs review » Active

Thx. I've filed this and other issues in Component Schema and Bulma Components for work I plan to do. They don't generally include enough detail for others to take on. I'll assign to myself accordingly.

  • nedjo committed fadfadc on 1.0.x 
    Issue #3176308 by nedjo: Use component_tag schema type for tag variable
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Title: Use tag schema type for tag variable » Use component_tag schema type for tag variable
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.