Closed (fixed)
Project:
Build Hooks
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Sep 2020 at 01:15 UTC
Updated:
11 Oct 2020 at 22:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
larowlanComment #3
Pooja Ganjage commentedHi,
I am creating a patch for this issue.
Kindly review the patch once.
Thanks.
Comment #4
Pooja Ganjage commentedComment #6
larowlanthe logger service isn't the one we need a variable for (its only called once) - instead its the trigger service we need a variable for.
Comment #7
anushrikumari commentedCreated the patch as per comment #6 @larowlan please review.
Comment #8
larowlanThanks for this
let's reverse this one, we're only using it once in this function so there's no need to create a variable - unlike the other functions, where we use it twice
Comment #9
anushrikumari commentedI've made the suggested changes, please review.
Comment #10
larowlanThanks! 💪
Comment #11
larowlan