Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new1.78 KB
anishnirmal’s picture

Hi,

The Readme.txt looks good to me. It follows the standard and verified on the below points.

  • Line not exceeding 80 characters
  • It has the link to the maintainers page
  • Misspellings

We can change "Additionally, you can set up Buffer schedule to send you a email warning you" to "Additionally, you can set up Buffer
+schedule to send you an email warning you"

alonaoneill’s picture

StatusFileSize
new1.78 KB

Changed line as suggested.
Please review.

cmcintosh’s picture

Looks good I can work on merging it soon. Looks like I need to sort out how to merge it now.

volkswagenchick’s picture

Status: Needs review » Needs work
+++ b/README.md
@@ -0,0 +1,57 @@
+    3. In Buffer Options Select a buffer to add this content to. It will be published

Line 47 exceeds 80 characters and line 48 should have a hanging indent.

+++ b/README.md
@@ -0,0 +1,57 @@
++ schedule to send you an email warning you when the buffer gets low or runs out

Are there two "+" at the beginning of line 18??

alonaoneill’s picture

Status: Needs work » Needs review
StatusFileSize
new1.79 KB

Made changes in line 47.
Line 18 was changes as suggested in comment #3
Thanks

jqtnguyen’s picture

Status: Needs review » Needs work
  1. +++ b/README.md
    @@ -0,0 +1,57 @@
    ++ schedule to send you an email warning you when the buffer gets low or runs out
    

    It is very unclear to me what "+ schedule" is meant to be here. Is this an option within this module? Is it meant to convey that Buffer Schedule can be used in conjunction with another module or function? Suggestion to update this for clarity and, if the "+" is merely meant to convey "and", to use the word instead of the symbol, as "+" can have other connotations.

  2. +++ b/README.md
    @@ -0,0 +1,57 @@
    +    2. Navigate to Administration > Content and create new Content type.
    +    3. In Buffer Options Select a buffer to add this content to. It will be
    +       published based on that buffer's settings.
    

    These instructions don't match up with the UX. Please consider changing to something like:

    2. Navigate to Administration > Content > Content Buffer > Add Schedule to create a buffer schedule.
    3. When creating new content, in "Buffer Options", select a a buffer to add this content to. It will be published based on that buffer's settings.

alonaoneill’s picture

Status: Needs work » Needs review
StatusFileSize
new1.87 KB

Made changes! Thanks

anishnirmal’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. Moving it to RTBC. This code can be merged.

cmcintosh’s picture

Status: Reviewed & tested by the community » Closed (outdated)

Will correct this today in Drupal 9.x Version of the module.