Closed (outdated)
Project:
Buffer Schedule
Version:
8.x-0.0-alpha1
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
25 Jun 2019 at 16:30 UTC
Updated:
17 Sep 2021 at 01:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alonaoneill commentedComment #3
anishnirmal commentedHi,
The Readme.txt looks good to me. It follows the standard and verified on the below points.
We can change "Additionally, you can set up Buffer schedule to send you a email warning you" to "Additionally, you can set up Buffer
+schedule to send you an email warning you"
Comment #4
alonaoneill commentedChanged line as suggested.
Please review.
Comment #5
cmcintosh commentedLooks good I can work on merging it soon. Looks like I need to sort out how to merge it now.
Comment #6
volkswagenchickLine 47 exceeds 80 characters and line 48 should have a hanging indent.
Are there two "+" at the beginning of line 18??
Comment #7
alonaoneill commentedMade changes in line 47.
Line 18 was changes as suggested in comment #3
Thanks
Comment #8
jqtnguyen commentedIt is very unclear to me what "+ schedule" is meant to be here. Is this an option within this module? Is it meant to convey that Buffer Schedule can be used in conjunction with another module or function? Suggestion to update this for clarity and, if the "+" is merely meant to convey "and", to use the word instead of the symbol, as "+" can have other connotations.
These instructions don't match up with the UX. Please consider changing to something like:
2. Navigate to Administration > Content > Content Buffer > Add Schedule to create a buffer schedule.
3. When creating new content, in "Buffer Options", select a a buffer to add this content to. It will be published based on that buffer's settings.
Comment #9
alonaoneill commentedMade changes! Thanks
Comment #10
anishnirmal commentedLooks good. Moving it to RTBC. This code can be merged.
Comment #11
cmcintosh commentedWill correct this today in Drupal 9.x Version of the module.