After installed Broken Anchor it broke my whole website with some php code.
Tested on HeartInternet virtual hosting.

CommentFileSizeAuthor
Clipboard01.jpg590.26 KBkenorb

Comments

kenorb’s picture

Title: Broken Anchor breaking the Drupal website » Broken Anchor breaking the Drupal website (stable Broken Anchor is not stable)
Status: Active » Needs review

Solution: Changing short_open_tag to <?php start worked.

Ignoring hundreds of errors similar to:

warning: array_merge() [function.array-merge]: Argument #1 is not an array in /home/sites/co.uk/public_html/includes/common.inc on line 3169.
warning: array_keys() [function.array-keys]: The first argument should be an array i
warning: Invalid argument supplied for foreach() in /home/sites/co.uk/public_html/sites/all/modules/contributions/views/includes/view.inc on line 1633.
sites/all/modules/contributions/views/includes/view.inc on line 1633.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') ORDER BY vid, position' at line 1 query: SELECT * FROM views_display WHERE vid IN () ORDER BY vid, position in /home/sites/co.uk/public_html/sites/all/modules/contributions/views/includes/view.inc on line 1259.

#354432: Many errors on insall--unusable
#354125: Broken Anchor SQL Error
#354430: Invalid PHP tag

WTF?!?!???
Disabling the module, until the next stable release. If there will be any.

Using short php tag is depreciated, most of the server doesn't support it anymore.
Please change it.

Yoran’s picture

Status: Needs review » Fixed

Keep cool, It would have been nice to send me an email instead of getting mad at me.

Anyway, everything seems to be fine with RC3

kenorb’s picture

Sorry:)
I like testing some nice new modules, but I'm always pessimist when installing some new modules, because 1/4 of it always breaking something with fatal errors and you never don't know why.
But it's good to know that this module is not suspended as many others:)
Thank you.

Yoran’s picture

No and it will not :) I have many modules on my own site, when I put one here, it's to maintain them, not just for fun ;-) I'll just try to watch this issues page more often in the future :)

kenorb’s picture

But some modules provides some nice solution which are very useful and sometimes you realize after than that you need that functionality and you can also improve those modules by testing it, so it's not only for fun.
But I wondering why there is no any test bot which will check the basic errors before you installing it. It will save lot of time and problems.
#362931: Automated testing for contrib modules

Yoran’s picture

By "not for fun", I was meaning that as I choose those two modules of mine to put them in this forge, I realy don't want them to be dead code.

About testing, As I'm from Java world, I fully agree with your vision. specially when mistakes are like mine (short php tags or wrong mysql fields). As I am (as many module authors I think) a full time PHP dev, this can be really usefull.

With an higher point of view, the all Drupal project need QA Process soon or later. A real validation cycle for module with a recognized compliance label is the only way to compete with mambo/joomla people.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.