Problem/Motivation

Coming here from #3471021: Webform newsletter subscription integration checkbox & handler should we merge this into the Brevo module maybe and join forces together as maintainers?

Think that might make sense, also API-wise?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

anybody created an issue. See original summary.

stijnstroobants’s picture

Sounds logic, as long as we don't need to install unnecessary functionalities to only send contacts to Brevo-lists.
I still didn't check the Brevo-module enough

anybody’s picture

@stijnstroobants I'd think of a master "Brevo" module that allows storing the API credentials and provides the basic API methods, maybe not even any end-user-facing functionality. Submodules and contrib should then base on that.

We implemented something similar for the Posthog module, if you'd like to take a look.
Please note that I'm not the Brevo module owner or key-maintainer, just using Brevo and try to help with the module roadmap. Where should we discuss that further?

Another alternative would be to keep this in contrib, but use the Brevo module as base for API credentials. But I think it would also be helpful to have you as experienced Brevo developer!

anybody’s picture

PS: Furthermore I think that many "base" functionalities might be similar or even the same, so would make sense to share that also on the UI level, e.g. forms. Shouldn't be much different to handle a block for newsletter subscription or a commerce checkout step with newsletter subscription checkbox for example one level deeper. So with a base module common functionality can be shared across all levels?

kensae’s picture

I'm also using the brevo module and the brevo_webform_handler would be a useful addition.
I 've added a conditional check for the Brevo module's services. The handler now dynamically detects if the Brevo services are available; if they are, it utilizes them for processing. Otherwise, the logic seamlessly falls back to the existing implementation to ensure uninterrupted functionality.

I'll create a merge request for review.

anybody’s picture

Nice @kensae thanks! I think it would be great if the maintainer agrees to merge this into the main module and join as maintainer there! :)

kensae’s picture

Status: Active » Needs review
anybody’s picture

#3471021: Webform newsletter subscription integration checkbox & handler now integrated this, so @stijnstroobants might consider maring this module obsolete, link https://www.drupal.org/project/brevo and join the team?

anybody’s picture

@stijnstroobants what to you think? At least some information might be added on the module page?