I suggest standardizing all Contacts API interactions across this module and its plugins by using the ContactsApiClientHelper class as the default helper. Currently, there is a lack of consistency; for instance, BrevoListsSubscriber and the CreateContactQueue worker handle contact creation using different logic.

To ensure the helper can support all necessary data, we should also expand the arguments for the createContact and updateContact functions. Specifically, these functions should be updated to accept contact attributes and the updateEnabled parameter.

Issue fork brevo-3588474

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kensae created an issue. See original summary.

kensae opened merge request !18

kensae’s picture

kensae commented
Status: Active » Needs review
renrhaf’s picture

renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
commented
Status: Needs review » Needs work
kensae’s picture

kensae commented
Status: Needs work » Needs review

renrhaf’s picture

renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

GREAT work once again @renrhaf!! Thank you so much!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.