When changing between higher levels of logging, e.g. from 5 to 4, I get

Notice: Undefined index: botcha_statistics_reset in botcha_admin_settings() (line 64 of modules/botcha/botcha.admin.inc).

CommentFileSizeAuthor
#6 botcha-undefined_variable_notice-1840724-6.patch3.36 KBPatchRanger
#4 botcha-undefined_variable_notice-1840724-4.patch3.48 KBPatchRanger
#3 botcha-undefined_variable_notice-1840724-3.patch3.68 KBPatchRanger
#1 botcha-undefined_variable_notice-1840724-test.patch1.49 KBPatchRanger

Comments

PatchRanger’s picture

PatchRanger commented
Status: Active » Needs review
StatusFileSize
new botcha-undefined_variable_notice-1840724-test.patch1.49 KB

Should break since there are only tests for functionality that does not work yet.

Status: Needs review » Needs work

The last submitted patch, botcha-undefined_variable_notice-1840724-test.patch, failed testing.

PatchRanger’s picture

PatchRanger commented
Status: Needs work » Needs review
StatusFileSize
new botcha-undefined_variable_notice-1840724-3.patch3.68 KB
PatchRanger’s picture

PatchRanger commented
StatusFileSize
new botcha-undefined_variable_notice-1840724-4.patch3.48 KB

A typo fixed.

PatchRanger’s picture

PatchRanger commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

Fixed in D7: http://drupalcode.org/project/botcha.git/commit/61af7f9.

PatchRanger’s picture

PatchRanger commented
StatusFileSize
new botcha-undefined_variable_notice-1840724-6.patch3.36 KB
PatchRanger’s picture

PatchRanger commented
Status: Patch (to be ported) » Needs review
PatchRanger’s picture

PatchRanger commented
Status: Needs review » Fixed

Fixed for D6 also: http://drupalcode.org/project/botcha.git/commit/318e019.

iva2k’s picture

iva2k commented
Status: Fixed » Needs review

After a quick glance at the patch I noticed the test may fail occasionally (one in a million) when both rand()'s return 0 and there is a bug not resetting the counts. It makes sense to use a simple change to rand(1,...) instead of rand(0,...) to ensure the counts are non-zero to start from and test is 100% reliable. Reference: PHP rand()

PatchRanger’s picture

PatchRanger commented
Status: Needs review » Fixed

Nice shot, thank you!
Fixed for both versions: http://drupalcode.org/project/botcha.git/commit/047d599 & http://drupalcode.org/project/botcha.git/commit/c783cd1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.