regular expressions match the beginning $path, which now includes $base_path. $base_path should be set in boost_cache_directory() not in boost_init(). This will also help with the _boost_rmdir_rf() rewrite #477848: Difficulties w/ Boost 6.x1.0-alpha4 - Multi-site, Folder Permissions - _boost_rmdir_rf().

CommentFileSizeAuthor
#7 boost-480182.2.patch5.34 KBmikeytown2
#6 boost-480182.1.patch5.32 KBmikeytown2
#5 boost-480182.patch4.7 KBmikeytown2
#4 boost-480182.patch4.7 KBmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
Component: User interface » Caching logic
Priority: Normal » Critical

shoot... the drupal/user page is getting cached; which can be used to login. drupal/user/login is not being served even though it is being cached.

mikeytown2’s picture

mikeytown2 commented

Newer rules to match whats in boost_cache_directory()

  RewriteCond %{REQUEST_URI} (^/(admin|cache|misc|modules|sites|system|themes|user/(login|register|password))|(.xml|/(feed|comment/reply|user))$) [OR]

Also found a bug this

  // Don't cache comment reply pages
  if (preg_match('!^comment/reply!', $normal_path))
    return FALSE;

should be this

  // Don't cache comment reply pages
  if (preg_match('!comment/reply$!', $normal_path))
    return FALSE;
mikeytown2’s picture

mikeytown2 commented
Priority: Critical » Normal

After testing, boost/drupal is smart enough to not fail even though the login page is cached.
Here's the new set of rules to go in; makes sure if this happens again, it will not even serve those cached pages if they do exist.

  RewriteCond %{REQUEST_URI} (^/(admin|cache|misc|modules|sites|system|themes))|(/(feed|comment/reply|user|user/(login|password|register))$) [OR]
mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new boost-480182.patch4.7 KB

proposed changes

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new boost-480182.patch4.7 KB

minor fixes to above patch

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new boost-480182.1.patch5.32 KB

here's the correct file

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new boost-480182.2.patch5.34 KB

j/k its here... i need to get some sleep.

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.