Please see my comment here: http://drupal.org/node/1537736#comment-6576196

wouldnt it better to avoid that extra query and the notice in the log messages if no files removed? especially if you run cron quite often.

cheers N20

CommentFileSizeAuthor
#3 1807186-3-expire-debug-message.patch636 bytesgeerlingguy

Comments

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
Status: Active » Closed (works as designed)

From BGM, reducing the watchdog verbosity on that thread (for 6,x) fixes the issues

http://drupal.org/node/1537736#comment-6564378

From my comment, even expiring 0 files is useful for debugging.

http://drupal.org/node/1537736#comment-6576514

geerlingguy’s picture

geerlingguy commented
Version: 7.x-1.0-beta2 » 7.x-1.x-dev
Assigned: » Unassigned
Priority: Minor » Normal
Status: Closed (works as designed) » Active

Would love to be able to disable these messages without hacking the module; is there any way we could set these messages to not save if the boost_message_debug() variable is not set? On a few of my smaller sites, this is pretty much the only message in the watchdog, but it drowns out the few other messages that I'd like to see from time to time, since it's shown every cron run.

On the Drupal 7 version of Boost, it seems there is no verbosity setting, and even if there was, boost_cron() isn't respecting it. The verbosity setting only applied to 6.x: #531100: Add verbose setting for watchdog messages.

geerlingguy’s picture

geerlingguy commented
Title: Expired stale 0 files from... » Don't log cache expiration messages on cron if debug info not set
Status: Active » Needs review
StatusFileSize
new 1807186-3-expire-debug-message.patch636 bytes

Attaching patch; basically, don't log this unless someone checks the debug info box on admin/config/system/boost/debug.

bgm’s picture

bgm commented
Status: Needs review » Fixed

Thanks for the patch. Committed to 7.x-1.x.

This was indeed how it was in 6.x-1.x, but since 7.x-1.x is mostly a rewrite, we didn't have the same behavior.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.