I just install a new CVS site. My first module install is bookreview.
When i go to admin - Module and set it in => OK
When i go to the link : http://localhost/drupal470/?q=admin/settings/bookreview

i have 2 errors :

_form_get_error function does not exist in legacy.inc (at many places).

and

warning: implode(): Bad arguments. in c:\programme\easyphp1-8\www\drupal470\includes\form.inc on line 194.

CommentFileSizeAuthor
#4 bookreview.module_0.patch27.56 KBKoyaman

Comments

chx’s picture

chx commented
Project: Drupal core » Book Review
Version: x.y.z » 4.6.x-1.x-dev
Component: admin.module » Code

Note that I have requested for the removal of legacy.inc . in this case, node form needs forms API update.

chx’s picture

chx commented

By "in this case" I meant: in the case of book review, regardless of legacy.inc, the node form needs to be updated to forms API, anyways.

jeremy’s picture

jeremy commented
Version: 4.6.x-1.x-dev » master

Moving this back from 4.6 to CVS -- currently this module is not updated to work with the upcoming 4.7 release. Patches are welcome, otherwise I'll get to it when I get to it... ;)

Koyaman’s picture

Koyaman commented
StatusFileSize
new bookreview.module_0.patch27.56 KB

I've tried to get it work with cvs core (hoping I use the right way to do things !), feel free to advice or comment...

Notes :
I've packed some of the fields to reduce the page length and directly show the review... but I'm not really satisfied with the result. The field's sizes need to be adjusted to get a more readable form. There's no input validation or required fields.

The old version uses something like "authors][$i" to create a dynamic array of authors in the form (using Preview to add more room). It doesn't seem to work with the new API (or I didn't understand how to get it work !). I've replace this with a manual storing/retrieveing of an "author-$i" variable.

The "Update your module" handbook says check_output is replaced by check_markup (adding some security check), so I've query-replaced.

deekayen’s picture

deekayen commented
Assigned: Unassigned » deekayen
Status: Active » Fixed

I committed this and branched for 4-7 with a few small mods.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)