Hi!

Using the fullblock api integration ( great work, btw ), I realised that there's no way I could show events end time.

First of all I configured the block to always show the end time:

{'displayEventEnd':true}

but it yet didn't show the end time, because the API doesn't provide that information:

BookableCalendarApiController.php

        $opening_array[] = [
          'title' => $bookable_calendar->title->value,
          'start' => date('Y-m-d H:i:s', $instance->date->value),
          'end' => date('Y-m-d H:i:s', $instance->date->value),
          'url' => $path,
        ];

Shouldn't it be like this?

        $opening_array[] = [
          'title' => $bookable_calendar->title->value,
          'start' => date('Y-m-d H:i:s', $instance->date->value),
          'end' => date('Y-m-d H:i:s', $instance->date->end_value),
          'url' => $path,
        ];

Regards, Diego

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dbrouard created an issue. See original summary.

josh.fabean made their first commit to this issue’s fork.

josh.fabean’s picture

Version: 8.x-1.x-dev » 2.1.x-dev

  • josh.fabean committed ba9e3f3 on 2.1.x
    Issue #3314570 by josh.fabean: Not showing end time using fullcalendar...
josh.fabean’s picture

Hey dbrouard, good find!

I got that patched and pushed up to latest dev for you to test out.

josh.fabean’s picture

That is now pushed out to version 2.1.5

josh.fabean’s picture

Status: Active » Fixed
dbrouard’s picture

Hi Josh, it's perfect, thanks!

Great work BTW, this module is very very useful :)

josh.fabean’s picture

Good to hear and thanks!

josh.fabean’s picture

Status: Fixed » Closed (fixed)