t() calls should be avoided in classes. [#3291632]

$ phpcs --standard=Drupalpractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml bookable_calendar/

FILE: C:\xampp\htdocs\contribution\web\modules\contrib\bookable_calendar\src\BookableCalendarOpeningInstanceViewsData.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 15 WARNINGS AFFECTING 15 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
32 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
33 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
34 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
35 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
36 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
40 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
41 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
42 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
43 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
44 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
75 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
80 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
81 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\contribution\web\modules\contrib\bookable_calendar\src\BookableCalendarOpeningViewsData.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 15 WARNINGS AFFECTING 15 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
32 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
33 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
34 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
35 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
36 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
40 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
41 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
42 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
43 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
44 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
75 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
80 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
81 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\contribution\web\modules\contrib\bookable_calendar\src\BookingViewsData.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 15 WARNINGS AFFECTING 15 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
32 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
33 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
34 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
35 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
36 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
40 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
41 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
42 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
43 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
44 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
75 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
80 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
81 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

Comment	File	Size	Author
#6	interdiff_2-6.txt	29.27 KB	urvashi_vora
#6	t_calls_replaced-3291632-6.patch	39.07 KB	urvashi_vora
#2	T_calls_should_be_avoided-3291632-2.patch	9.31 KB	rakhi soni

Issue fork bookable_calendar-3291632

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3291632-t-calls-should compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

21 June 2022 at 07:48

Rakhi Soni created an issue. See original summary.

Comment #2

rakhi soni commented 21 June 2022 at 07:53

Assigned:	rakhi soni	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	T_calls_should_be_avoided-3291632-2.patch	9.31 KB

I have created a patch to fix the issue of "t() calls should be avoided in classes.",, please review.

Comment #3

urvashi_vora commented 20 July 2022 at 12:07

Assigned:

Unassigned

» urvashi_vora

Hi,
I will review this.

Comment #4

urvashi_vora commented 21 July 2022 at 04:20

Hi @Rakhi,

Your patch was applied cleanly.

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/bookable_calendar-3291632$ git apply -v T_calls_should_be_avoided-3291632-2.patch
Checking patch src/BookableCalendarOpeningInstanceViewsData.php...
Hunk #4 succeeded at 86 (offset 11 lines).
Checking patch src/BookableCalendarOpeningViewsData.php...
Checking patch src/BookingViewsData.php...
Applied patch src/BookableCalendarOpeningInstanceViewsData.php cleanly.
Applied patch src/BookableCalendarOpeningViewsData.php cleanly.
Applied patch src/BookingViewsData.php cleanly.

Thanks for the patch.

Comment #5

urvashi_vora commented 21 July 2022 at 04:22

Status:

Needs review

» Needs work

However, it still contains some t() calls. Marking it to "Needs work".

I am working on this.

Comment #6

urvashi_vora commented 21 July 2022 at 04:30

Assigned:	urvashi_vora	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	t_calls_replaced-3291632-6.patch	39.07 KB
new	interdiff_2-6.txt	29.27 KB

Hi,

Please review this patch.

Thanks

Comment #7

anoopsingh92

Rajasthan, India

commented 21 July 2022 at 08:41

Status:

Needs review

» Needs work

Hi @urvashi_vora,

I reviewed your patch. Your patch has been applied successfully.

Lenovo@LAPTOP-PDE747K8 MINGW64 /c/xampp/htdocs/drupal-9/web/modules/contrib/bookable_calendar-3291632 (3291632-t-calls-should)
$ git apply -v t_calls_replaced-3291632-6.patch
Checking patch bookable_calendar.install...
Checking patch src/BookableCalendarOpeningInstanceViewsData.php...
Checking patch src/BookableCalendarOpeningViewsData.php...
Checking patch src/BookingViewsData.php...
Checking patch src/Entity/BookableCalendar.php...
Checking patch src/Entity/BookableCalendarOpening.php...
Checking patch src/Entity/BookableCalendarOpeningInstance.php...
Checking patch src/Entity/Booking.php...
Checking patch src/Entity/BookingContact.php...
Applied patch bookable_calendar.install cleanly.
Applied patch src/BookableCalendarOpeningInstanceViewsData.php cleanly.
Applied patch src/BookableCalendarOpeningViewsData.php cleanly.
Applied patch src/BookingViewsData.php cleanly.
Applied patch src/Entity/BookableCalendar.php cleanly.
Applied patch src/Entity/BookableCalendarOpening.php cleanly.
Applied patch src/Entity/BookableCalendarOpeningInstance.php cleanly.
Applied patch src/Entity/Booking.php cleanly.
Applied patch src/Entity/BookingContact.php cleanly.

Thanks for the patch.

Thanks