Problem/Motivation

The book_navigation_without_tree field does not appear in the position configured on "Manage display". This is because it is put into $build['book_navigation'] instead of $build['book_navigation_without_tree'].

Proposed resolution

Use the correct key.

Remaining tasks

Implement.

User interface changes

None, except that the field appears in the correct location.

API changes

None.

Data model changes

None.

Issue fork book-3587241

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

liam morland opened merge request !177

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review
dbielke1986’s picture

dbielke1986 commented
Related issues: +#3585949: Field "Book navigation (without tree links)" not working
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

I think this is a different issue.

dbielke1986’s picture

dbielke1986 commented

It describes the same problem that was part of the other issue:

...
The last open point I will check is, why the ordering is not correct, if I only use "Book navigation (without tree links)"
...

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs test

Needs tests

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
Issue tags: -Needs test

Tests added and are passing. As expected, the test-only job does not pass and its failure is the thing fixed by this merge request.

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Would you accept a backport of this to 2.0.x?

smustgrave’s picture

smustgrave commented
Version: 3.0.x-dev » 2.0.x-dev
Status: Fixed » Patch (to be ported)

For this yes

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 2.0.x-dev » 3.0.x-dev
Status: Patch (to be ported) » Fixed

Sorry, I must have recalled incorrectly which version I had installed. book_navigation_without_tree is not in 2.0.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.