Module looks great, I'm not planning to use it for now but had faced similar issue in one of my project. IMO you should check once for issue here - https://www.drupal.org/project/restrict_role_login_by_ip/issues/2978274 and plan on adding IP V6 support.

Check for:
* Proxy / CDN
* Varnish
* Balancers

Get IP properly considering all this and also work on supporting IPV6

Comments

nikunjkotecha created an issue. See original summary.

Chetan Sharma’s picture

Chetan Sharma commented

nikunjkotecha,

I have added the functionality for supporting IP V6 & Proxy / CDN, Varnish, Balancers. Please verify.

Chetan Sharma’s picture

Chetan Sharma commented
Status: Active » Needs review
nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented

awesome, hope the referenced helped you

I won't be able to test it (in near future), I checked the commit and looks good

You can use commit message from issue to link it for reference, read more at https://www.drupal.org/node/52287

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.