Hi, I modified block-cookies.js so it blocks cookies by default instead of waiting for the user to click "deny" on the EU banner, since the GDP regulation states that cookies should be blocked by default unless the user gives consent to accept cookies.

I changed the getter and setter definition based on this solution https://stackoverflow.com/a/33064438/25578 so it bypass EU module cookie. It means that the only cookie that can be set up by default is "cookie-agreed" any other cookie will be deleted / blocked.

Also removed the calls to document.__defineGetter__ and document.__defineSetter__ since these are deprecated and can stop working at any moment without notice.

I tested this on Firefox, Chrome, Safari and Internet Explorer 11 and it's working well in all browsers, maybe this patch is something you want to consider to be fully GDPR compliant.

CommentFileSizeAuthor
#3 block_cookies-block_cookies_by_default-3-D8.patch1.5 KBnwom
#2 block_cookies-block_cookies_by_default-1-D8.patch1.62 KBjavi-er

Comments

javier_ created an issue. See original summary.

javi-er’s picture

javi-er commented
StatusFileSize
new block_cookies-block_cookies_by_default-1-D8.patch1.62 KB
nwom’s picture

nwom commented
StatusFileSize
new block_cookies-block_cookies_by_default-3-D8.patch1.5 KB

Thank you very much for the patch! I couldn't apply it at first, since the patch is using your folder structure. Normally the root must always be the module directory. I fixed and tested your patch and they work great! Please review.

javi-er’s picture

javi-er commented

Great! thanks for changing that, didn't noticed it when posted the patch, I tested it against a fresh install and it applies correctly for me.

javi-er’s picture

javi-er commented
Status: Needs review » Reviewed & tested by the community