Closed (fixed)
Project:
Block Class
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Nov 2022 at 09:59 UTC
Updated:
24 Dec 2022 at 20:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
raghavendra a m commentedHi, here is the updated patch for coding standard.
Comment #3
Arturo-q commentedHi, @Raghavendra A M, are you still working on it? I believe that you have forgotten to unassign yourself.
Comment #4
raghavendra a m commentedComment #5
karanpagare commentedNot able to apply patch #2 , getting error unrecignized input.
Comment #6
jaydev bhatt commentedHello @karanpagare,
Thank you for testing this. This could be due to the different encoding standard while making the patch file.
attaching the updated patch file.
and putting this into Needs Review state. for further verification.
Comment #7
Arturo-q commentedHi, I will review patch 6.
Comment #8
Arturo-q commentedHi, I've reviewed patch #6, there are some changes on the JS files that are breaking some functionalities, besides, I'm not getting those errors using PHPCS (The JS ones), so I've removed them.
Also, I found these CS warnings remaining:
I've fixed them too.
So, Kindly reviewed it.
Regards.
Comment #9
LeoAlcci commented@arturo1007, your patch didn't apply correctly, maybe you have a older version of the block class module?
Also, in the 2.x-dev those 3 warnings are fixed. Check https://git.drupalcode.org/project/block_class/-/blob/2.0.x/block_class....
Comment #10
Arturo-q commentedHi, @LeoAlcci you're right, this one should work.
kindly review it.
Comment #11
christyanpaim commentedComment #12
christyanpaim commentedWorks fine here
Comment #14
renatog commentedMoved to the dev branch
Thanks a lot everyone