Comments

Raghavendra A M created an issue. See original summary.

raghavendra a m’s picture

Status: Needs work » Needs review
StatusFileSize
new21.78 KB

Hi, here is the updated patch for coding standard.

Arturo-q’s picture

Hi, @Raghavendra A M, are you still working on it? I believe that you have forgotten to unassign yourself.

raghavendra a m’s picture

Assigned: raghavendra a m » Unassigned
karanpagare’s picture

Status: Needs review » Needs work

Not able to apply patch #2 , getting error unrecignized input.

jaydev bhatt’s picture

Status: Needs work » Needs review
StatusFileSize
new10.62 KB

Hello @karanpagare,
Thank you for testing this. This could be due to the different encoding standard while making the patch file.
attaching the updated patch file.
and putting this into Needs Review state. for further verification.

Arturo-q’s picture

Assigned: Unassigned » Arturo-q

Hi, I will review patch 6.

Arturo-q’s picture

Assigned: Arturo-q » Unassigned
StatusFileSize
new2.9 KB
new8.33 KB

Hi, I've reviewed patch #6, there are some changes on the JS files that are breaking some functionalities, besides, I'm not getting those errors using PHPCS (The JS ones), so I've removed them.
Also, I found these CS warnings remaining:

FILE: web/modules/contrib/block_class/block_class.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

I've fixed them too.
So, Kindly reviewed it.
Regards.

LeoAlcci’s picture

Version: 2.0.8 » 2.0.x-dev
Status: Needs review » Needs work

@arturo1007, your patch didn't apply correctly, maybe you have a older version of the block class module?

FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
---------------

Also, in the 2.x-dev those 3 warnings are fixed. Check https://git.drupalcode.org/project/block_class/-/blob/2.0.x/block_class....

Arturo-q’s picture

Status: Needs work » Needs review
StatusFileSize
new2.53 KB
new8.02 KB

Hi, @LeoAlcci you're right, this one should work.
kindly review it.

christyanpaim’s picture

Assigned: Unassigned » christyanpaim
christyanpaim’s picture

Assigned: christyanpaim » Unassigned
Status: Needs review » Reviewed & tested by the community

Works fine here

  • f1c294f committed on 2.0.x
    Issue #3324040 by Arturo1007, Raghavendra A M, Jaydev Bhatt,...
renatog’s picture

Status: Reviewed & tested by the community » Fixed

Moved to the dev branch

Thanks a lot everyone

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.