Problem/Motivation

When you enable the module, the method hook_help is not implemented.

Steps to reproduce

Download and activate the module and visit it's help page.

Proposed resolution

Implement the hook_help and describe the functionality of the module and it's usage.

Remaining tasks

Implement hook_help.

CommentFileSizeAuthor
#10 help.png51.88 KBBushra Shaikh
#10 After Patch.png34.93 KBBushra Shaikh
#10 Before Patch.png30.19 KBBushra Shaikh
#9 Screenshot from 2023-06-19 14-15-58.png58.4 KBnitin_lama
#9 Screenshot from 2023-06-19 14-16-13.png61.71 KBnitin_lama
#7 3339491-after-patch.png29.09 KBclarkssquared
#7 3339491-applying-MR.png62.89 KBclarkssquared
#6 beacon.patch958 bytesraveen_thakur51

Issue fork beyond_beacon-3339491

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Vadim Ansari created an issue. See original summary.

Vadim Ansari opened merge request !1

vadim ansari’s picture

vadim ansari commented
Assigned: vadim ansari » Unassigned
Status: Active » Needs review

Created MR for this issue.
Please review this.
Thanks.

tanuja bohra’s picture

tanuja bohra commented

After applying the MR1 and still hook_help() is not implemented.

raveen_thakur51’s picture

raveen_thakur51 commented

I have reviewed & Implemented the MR! on my Drupal website having version 9.5, PHP version - 8.1
The hook_help has been implemented successfully. Can be moved to RTBC!
Please & Thank You.

raveen_thakur51’s picture

raveen_thakur51 commented
StatusFileSize
new beacon.patch958 bytes

@davidkelso, I am adding a patch for it. Please review. And thank you.

clarkssquared’s picture

clarkssquared commented
Status: Needs review » Needs work
StatusFileSize
new 3339491-applying-MR.png62.89 KB
new 3339491-after-patch.png29.09 KB

Hi Vadim Ansari

I applied your MR !1 to my local and according to my terminal, it applies cleanly and successfully, however, when I visit the module again it seems that hook_help() was not implemented.

Please look at the screenshot attached for your reference.

Thank you

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review
StatusFileSize
new Screenshot from 2023-06-19 14-16-13.png61.71 KB
new Screenshot from 2023-06-19 14-15-58.png58.4 KB

I've looked into. It seems like file name wasn't updated. I've updated the file name as per module machine name (beyond_beacon). Please review.

validation

validation

Bushra Shaikh’s picture

Bushra Shaikh commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch.png30.19 KB
new After Patch.png34.93 KB
new help.png51.88 KB

I have verified and applied MR !1 the on 9.5.8, help() is added cleanly. Added screenshots for reference.

Can be moved to RTBC+1.