We need:

  • BeanSlidePlugin interface
  • CTools plugin
CommentFileSizeAuthor
#8 beanslide_1491640-7-WIP.diff12.17 KBadamdicarlo
#2 beanslide_1491640-2.patch10.08 KBadamdicarlo

Comments

duellj’s picture

duellj commented

Adam, I committed the 2.x branch, so feel free to start developing against it

adamdicarlo’s picture

adamdicarlo commented
Status: Active » Needs review
StatusFileSize
new beanslide_1491640-2.patch10.08 KB

This is very much a work in progress. Thoughts?

adamdicarlo’s picture

adamdicarlo commented

If this seems decent I'll commit it and go from there... but I'd like some ideas first about how to do this and even how to do what the patch already does better. It's mostly based on bean module's code at the moment.

bleedev’s picture

bleedev commented

Overall this looks like a great start. Enabling beanslide after the patch is applied produces the following error however.

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'title' cannot be null: INSERT INTO {menu_router} (path, load_functions, to_arg_functions, access_callback, access_arguments, page_callback, page_arguments, delivery_callback, fit, number_parts, context, tab_parent, tab_root, title, title_callback, title_arguments, theme_callback, theme_arguments, type, description, position, weight, include_file) ...

Side note, should beanslide_cycle be enabled by default? Otherwise enabling beanslide won't provide any functionality.

adamdicarlo’s picture

adamdicarlo commented

I'm thinking of not using CTools plugins for this. What's the advantage of using CTools for plugins? Drupal 7 has autoloading built in, for one thing, so what's the point of hook_ctools_plugin_directory()? I can easily invoke hook_beanslide_types() myself and use autoloading....

bleedev’s picture

bleedev commented

I can't see a particular reason to use CTools plugins if we can get the same result with the build in autoloading ... Just my 2 cents.

adamdicarlo’s picture

adamdicarlo commented
Title: CTools integration to support BeanSlide plugins » Bean Slide: Refactor slideshow types into plugin classes
Version: » 7.x-1.x-dev

I've been working on this refactor with a lightweight plugin system. Here's what I currently have. This is relative to the current 7.x-2.x HEAD which should be identical to 7.x-1.x at the moment.

adamdicarlo’s picture

adamdicarlo commented
Status: Needs review » Needs work
StatusFileSize
new beanslide_1491640-7-WIP.diff12.17 KB

D'oh, file attachments get lost if the issue node form doesn't validate...

Also to be clear, this still needs a lot of work, and doesn't necessarily warrant anyone to spend time looking at it. Just want to make it known I'm working on this.