The blocks do not display retweets (include_rts is not set and defaults to false).
As a result the select box 'Number of items' is a bit misleading since Twitter always includes retweets in the count:

We include retweets in the count, even if include_rts is not supplied. It is recommended you always send include_rts=1 when using this API method.

(https://dev.twitter.com/rest/reference/get/statuses/user_timeline)

How about including retweets ? Attached is a patch that does that. We could also add a checkbox in the block config interface to let the user decide whether retweets should be included or not.

Comments

fengtan created an issue. See original summary.

delmarr’s picture

StatusFileSize
new2.19 KB

Added an option to select retweets, but in my submit handler I went overboard with a

drupal_flush_all_caches();

Could be better handled by only clearing the bean cache.

I also noticed this in twitter_pull.module, could be useful

/**
 * Implements hook_flush_caches().
 */
function twitter_pull_flush_caches() {
  return array(TWITTER_PULL_CACHE_TABLE);
}
fengtan’s picture

Title: Include retweets » Add checkbox to include retweets
StatusFileSize
new1.66 KB

I think it is a good idea to turn this into a checkbox.

Could be better handled by only clearing the bean cache.

The cache problem seems to lie in the twitter_pull module: toggling the 'Display re-tweets' checkbox in bean_twitter_pull does not invalidate the cache in twitter_pull. Opened #2734361: Cache should get invalidated when retweets or replies are toggled and re-rolled #2 so it does not flush all caches.