It would be nice if there was a way to enable a "view all banners" page accessible to users.

As in, make a page available that when navigated to, it would show all the banners (or perhaps all banners of a group or filtered by some other criteria) in a list format.

Perhaps Pay-per-show sites wouldn't need this feature, but some of the sites I maintain are rather altruistic in nature, and it would be nice to have an easy way to display all banners in one place, so that visitors could see all contributors, supported sites, etc.

Perhaps weighting them in the list based on the show-weight (views) setting would be a good idea, for those who want a complete listing, but still want to weight certain banners as more important than others.

Of course, this feature could end up having to display a lot of banners, and perhaps paging of some sort would need to be implemented.

Comments

Anonymous’s picture

Anonymous (not verified) commented
Component: User interface » Code

I wrote something that can do this:

/**
* Create banner table
*
* Returns some html code to show all banners in a table.
*
* @param integer $group group of the banner in the theme
* @param integer $colums number of colums table shall have
* @return string proper HTML to show the banner
*/
function banner_table($group = 0, $colums = 5) {
    if (user_access('show banners')) {
        $result = "<div class=\"banners\"><table><tbody>\n<tr>\n";
        $i = 0;

        $query = db_query('SELECT * FROM {banner} WHERE status = 1 AND position = ' . $group);
        while ($banner = db_fetch_object($query)) {
            if($i == $colums) {
                $i = 0;
                $result = $result . "</tr>\n<tr>\n";
            }
            $i++;

            $result = $result . "  <td>".theme('banner_show', $banner)."</td>\n";
        }

        return $result . "</tr>\n</tbody></table></div>";
    }
}



Put it somewhere in banner.module, it can then be called like this <?php return banner_display([group], [number_of_colums]); ?>
It outputs a table with all banners in the desired group.

DeVill-1’s picture

DeVill-1 commented

I'm new to webmastering.
Could you tell me how to do a call?
I have Drupal 4.6, phpMyAdmin, and cPanel.

Thanks.

wulff’s picture

wulff commented

This functionality will basically come for free with the upcoming version of banner.module, since it features banners-as-nodes.

wulff’s picture

wulff commented
Status: Active » Closed (fixed)

Closing this. Please open a new issue if you wish to have this backported to 4.6 or included in the current non-node cvs version.