Problem/Motivation

Currently the "BanAdmin" page (IP address bans) UX is not very nice:

  1. The Ip address input + the add above the table is very untypical and might be mistaken with a table filter.
  2. It would be nice to collapse the table, to quickly access the buttons under the table.
  3. Once #3582177: Rewrite IP allowlist using a settings.php setting is resolved we can also show the whitelisted ips as a read only list.

Steps to reproduce

Proposed resolution

Improve the "BanAdmin" page (IP address bans):
Put the ip address input + add button under the table in its own dedicated "details" wrapper.
Put the table inside a details wrapper.
Show the ip "allowlist" above the table in a details wrapper (collapsed by default)

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ban-3582653

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

grevil’s picture

grevil commented
Parent issue: » #3575766: [META] 1.1.x UX-Improvements
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3575759: Add (starts with) filtering for banned IPs table

#3575759: Add (starts with) filtering for banned IPs table could get integrated once this is done!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Improve the "BanAdmin" page (IP address bans) » Improve the "BanAdmin" page (IP address bans) using details containers
Issue tags: +UX

grevil opened merge request !21

grevil’s picture

grevil commented
Status: Active » Postponed

All done! Ready for review, but postponed on #3582177: Rewrite IP allowlist using a settings.php setting (ban.allowlist) service

grevil’s picture

grevil commented

The last test failures should be resolved, when merging #3582177: Rewrite IP allowlist using a settings.php setting (ban.allowlist) service (at least one of them).

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@grevil RTBC from my side!

Please decide if we should also merge #3575759: Add (starts with) filtering for banned IPs table afterwards or keep it postponed on the frontend library. See my last comment.

grevil’s picture

grevil commented

Alright, this is good to go now! The help page is also properly displayed now! Let's wait for the tests to go green.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Postponed » Needs work

PHPStan and phpunit are unhappy

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Okay textual improvements done, please take a final look @grevil then we can merge it and tag beta2.

grevil’s picture

grevil commented

LGTM!

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • grevil committed cfdd7ceb on 1.1.x 
    feat: #3582653 Improve the "BanAdmin" page (IP address bans) using...