Phase 1 Cleanup review items for Stable Release

After trimming down the module to eliminate all Pareview test errors/warnings there were still some code remnants that needed cleaned up, even thou the module worked great there were still a few items that I overlooked.

1. Fixed the configure link
2. Removed bacnet_admin_settings_submit because it is never called.
3. Added function bacnet_uninstall() to bacnet.install

(I think these all originated when trying to embed the bacnet site map feature and bacnetsite content type feature into the base module at the same time I was trying to address review comments. I got confused about the various pieces I was working on, and where I was working on them in my local dev environment. )

Cleanup Pareview review

Review of the 7.x-1.x branch (commit b75bdc1):

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: /var/www/drupal-7-pareview/pareview_temp/bacnet.install
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
42 | WARNING | Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
--------------------------------------------------------------------------------

After last commit (b7627bc) I removed check_plain() from the two lines noted

DrupalPractice has found some issues with your code, but could be false positives.
FILE: /var/www/drupal-7-pareview/pareview_temp/bacnet.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
267 | WARNING | The extra check_plain() is not necessary for placeholders, "@"
| | and "%" will automatically run check_plain()
340 | WARNING | The extra check_plain() is not necessary for placeholders, "@"
| | and "%" will automatically run check_plain()
--------------------------------------------------------------------------------

Time: 85ms; Memory: 6.5Mb

Cleaning up these errors also,

Review of the 7.x-1.x branch (commit fbcbab7):

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: /var/www/drupal-7-pareview/pareview_temp/bacnet.module
--------------------------------------------------------------------------------
FOUND 3 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
14 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
129 | WARNING | [ ] A comma should follow the last multiline array item.
| | Found: ]
177 | ERROR | [ ] Inline comments must start with a capital letter
177 | ERROR | [ ] Inline comments must end in full-stops, exclamation marks,
| | or question marks
198 | ERROR | [x] Whitespace found at end of line
234 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
303 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 181ms; Memory: 8.5Mb

per https://www.drupal.org/node/2312955#comment-9167565

manual review:

1. bacnet_soap_get_value(): could you document @return here so that is clear what comes out of this function? See https://www.drupal.org/coding-standards/docs#return
2. bacnet_get(): this is vulnerable to XSS exploits. You are printing the result body of the request unsanitized to watchdog(). You need to apply check_plain() to the result of var_export() in the pre tags. This is a security blocker.