There are missing variables for the views filter for the availability calendar - lack of help text is the result so it is not major although it does raise PHP warnings in the log.

CommentFileSizeAuthor
#2 missing_variables-2696471-2.patch4.01 KBnickdickinsonwilde

Comments

NickWilde created an issue. See original summary.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Active » Needs review
StatusFileSize
new missing_variables-2696471-2.patch4.01 KB

Patch to fix missing text.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Status: Needs review » Needs work

If you are only adding missing variables , then how come that the patch deletes some other variables? I think that you made the changes on an older version and that subsequently you created a patch by comparing it with the latest version. Note that with the addition of the date range picker, some variables were added recently.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Status: Needs work » Fixed

I finally solved this by rewriting the Views (exposed) form handling. Thanks for reporting.

  • fietserwin committed 55e755e on 7.x-5.x 
    - [#2696471]: Missing Variables: solved by rewriting the views (exposed...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.