After disabling and uninstalling AC, the date/time types defined by default by AC are still available (and haven't been removed).

Steps to reproduce:

- Install AC
- Disable and uninstall AC
- look at admin/config/regional/date-time

At this time I don't have the time to produce a patch for this issue, but I'll try and post one later.

Comments

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented

Did you clear all caches? These date formats are defined by the hooks hook_date_format_types() and hook_date_formats(). So IMO they should be removed when clearing the caches. OTOH: if they are customized, I guess they get saved as any other date type/format that gets defined by the user himself (like overridden image styles). In that case they should not get removed by an uninstall as it has become user defined/customized data.

What do you think? Error or expected behavior?

pixelsmash’s picture

pixelsmash commented

I did clear all caches (just did it again to make sure), no result. If they are defined in a hook, they should be gone by now - I removed the module from the sites/all/modules folder.

I didn't do any customization, on top of that the edit links aren't available either (to revert to default or remove)

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented

Have a look at http://www.thedavidmeister.info/post/exporting-and-maintaining-custom-da.... Seems that a solution would be to call the code presented in that article by hook_uninstall(). If you write and test a patch that does so, I will commit it.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Issue summary: View changes
Status: Active » Closed (won't fix)

I do consider this an error in core, though arguably it could also be considered expected behavior.But as core does not provide any API to properly delete date format types, I'm not going to try to add some code to the uninstall hook to do so in my own way.