It's just nice and help developers figure things out more easily and probably harmless.

CommentFileSizeAuthor
#19 on_form_value_suspicion-2750097-19.patch3.08 KBznerol
#12 authcache-show_value_nested_keys-2750097-12.patch2.78 KBhanoii
#3 authcache-show_value_nested_keys-2750097-2.patch1.17 KBhanoii
#2 authcache-remove_members_only_widget-2750043-2.patch7.22 KBhanoii

Comments

hanoii created an issue. See original summary.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Active » Needs review
StatusFileSize
new authcache-remove_members_only_widget-2750043-2.patch7.22 KB

Patch attached.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
StatusFileSize
new authcache-show_value_nested_keys-2750097-2.patch1.17 KB

oops, wrong patch, sorry.

The last submitted patch, 2: authcache-remove_members_only_widget-2750043-2.patch, failed testing.

The last submitted patch, 2: authcache-remove_members_only_widget-2750043-2.patch, failed testing.

The last submitted patch, 2: authcache-remove_members_only_widget-2750043-2.patch, failed testing.

The last submitted patch, 2: authcache-remove_members_only_widget-2750043-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: authcache-show_value_nested_keys-2750097-2.patch, failed testing.

The last submitted patch, 3: authcache-show_value_nested_keys-2750097-2.patch, failed testing.

The last submitted patch, 3: authcache-show_value_nested_keys-2750097-2.patch, failed testing.

The last submitted patch, 3: authcache-show_value_nested_keys-2750097-2.patch, failed testing.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
StatusFileSize
new authcache-show_value_nested_keys-2750097-12.patch2.78 KB

Fixing tests that seems to be realated to this, others looks unrelated.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: authcache-show_value_nested_keys-2750097-12.patch, failed testing.

The last submitted patch, 12: authcache-show_value_nested_keys-2750097-12.patch, failed testing.

The last submitted patch, 12: authcache-show_value_nested_keys-2750097-12.patch, failed testing.

The last submitted patch, 12: authcache-show_value_nested_keys-2750097-12.patch, failed testing.

znerol’s picture

znerol commented

This patch looks a lot like #2460953-20: Support Ajax Webforms. I will review both of them and try to understand the difference / the benefit of each.

znerol’s picture

znerol commented
Status: Needs work » Needs review
StatusFileSize
new on_form_value_suspicion-2750097-19.patch3.08 KB

Let's use the same form as in Drupal core (see _form_builder_handle_input_element().

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

For me it's fine, as long as it helps figuring out the element!

  • znerol committed d702e74 on 7.x-2.x 
    Issue #2750097 by hanoii, znerol, firewaller: On form value suspicion...
znerol’s picture

znerol commented
Status: Needs review » Fixed

Thanks all for reporting the issue and helping with the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.