if one plays an audio file from a teaser view, he has effectively "read" the node (this is unique to audio nodes). Thus, I suggest we update the node history around the same point we record the click in our own stats. Just call: node_tag_new($nid)

CommentFileSizeAuthor
#7 audio.module_63976.patch1016 bytesdrewish
#6 audio.module_63976.patch.txt466 bytesdrewish

Comments

drewish’s picture

drewish commented

i'm not sure i follow exactly what you mean. plays/downloads are counted from any view...

moshe weitzman’s picture

moshe weitzman commented

node.module keeps track of what nodes each user has seen. it does so when you you view its full page (i.e. node/x). but with audio nodes, you don't have to go to the full page because the play button is in the teaser. so iam suggesting that when someone plays an audio file, audio.module should manually mark the node as read. node.module provides a function for this called node_tag_new()

drewish’s picture

drewish commented

that makes a lot more sense. should we call this when the file is downloaded as well?

moshe weitzman’s picture

moshe weitzman commented

yes, i think we should

leoburd’s picture

leoburd commented

Guys,

The pointed raised here is the same as the one described in http://drupal.org/node/63765 ...

.L.

drewish’s picture

drewish commented
Status: Active » Needs review
StatusFileSize
new audio.module_63976.patch.txt466 bytes

how's this patch look?

drewish’s picture

drewish commented
StatusFileSize
new audio.module_63976.patch1016 bytes

uh, working patch here.

drewish’s picture

drewish commented
Status: Needs review » Fixed

committed this to 4.7 (HEAD will be soon).

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)