Closed (works as designed)
Project:
Audio
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 May 2006 at 18:26 UTC
Updated:
15 May 2006 at 11:21 UTC
Apparently there are an incorrect number of quotes, I think, in the audio.install file for both cvs and 4.7.
Check code in this function here:
function audio_update_10() {
// don't bother if they haven't changed the allowed tags setting.
if (variable_get('audio_allowed_tags', FALSE)) {
$allowed = explode(' ', variable_get('audio_allowed_tags', ','artist title album track year genre'));
$browsable = explode(' ', variable_get('audio_browseable_tags', ','artist title album year genre'));
$settings = array();
$weight = -10;
foreach ($allowed as $tag) {
$settings[$tag] = array(
'required' '=> 0,
'hidden' => 0,
'writetofile' => 1,
'browsable' => (int) in_array($tag, $browsable),
'weight' => $weight++,
);
}
variable_set('audio_tag_settings', $settings);
}
return array();
}
Lines 38, 39, and 45 seem to have an extra / missing quote sign. [lines beginning with $allowed, $browsable, and 'required' ]
Good luck.
Albert
www.ithou.org
Comments
Comment #1
drewish commentedNot sure where you got your files. Feel free to compare what you posted to that in CVS: http://cvs.drupal.org/viewcvs/drupal/contributions/modules/audio/audio.i...
CVS looks right to me. Feel free to re-open this if I'm missing something.
Comment #2
ajwwong commentedhmmm... interesting... well, I downloaded cvs and 4.7 from the link here
http://drupal.org/node/28715/release
and it had the missing quote/extra quote problem, but your version looks good!
Thanks for the file....!! :-)
Comment #3
ajwwong commentedjust a followup on the "extra quote" phenomenon ---
seems to be due to some weird glitch in dreamweaver... when I look at the audio.install files in Smart CVS, they look fine, but every time I look at the *VERY SAME* files in dreamweaver MX, the extra quotes get added, somehow...
Very strange... Oh, well... I just cut and pasted the SQL commands from the install file to get the module databse structure setup... (fingers crossed!)
Thanks for all your help!
Albert