Updated code to be compatible with Drupal 11.
Tested on Drupal 10 and Drupal 11.

Issue fork auctions-3565399

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

girish_lnweb created an issue. See original summary.

girish_lnweb opened merge request !16

girish_lnweb’s picture

girish_lnweb commented
Status: Active » Needs review

Merge request created.
Tested on Drupal 10.x and Drupal 11.x.

  • skaught committed 074eaa07 on 3.0.x 
    Issue #3565399: Drupal 11 compatibility fixes
skaught’s picture

skaught
Primary language English
commented
Version: 2.2.2 » 3.0.x-dev

@girish_lnweb
thanks for stepping up! I am moving this work the to the 3.0.x dev branch branch directly and have push it forward.

FYI: As a part of how we monitor usage we do increment more strongly for clearer core version support (actual active community usage).

--
I'll try to continue to review and judge if a full release is now possible over next few days..

skaught’s picture

skaught
Primary language English
commented
Assigned: Unassigned » skaught
Status: Needs review » Active

skaught changed the visibility of the branch 3565399-drupal-11-compatibility to hidden.

andres alvarez’s picture

andres alvarez commented

But you are working on branch 3.x, but there are changes from 2.x that are not there.

andres alvarez’s picture

andres alvarez commented

For example, in branch 3.x there is no automatic refresh, but in 2.x there is.

skaught’s picture

skaught
Primary language English
commented

indeed the 3.x branch is for Drupal 11 concerns specifically. there are a few other open tickets around what you see the last commit on 2.x #3521548: File has a space: ' views.view.auctions_workflow_status_overview.yml' which has a conflict with another open ticket submitted with 'too may fixes at once'

with this keep in mind i'll merge/port of those more general bugs/tickets. this is normal for how i flow for tracing usage via https://www.drupal.org/project/usage/auctions. This is why 2.x is for D10 (:

andres alvarez’s picture

andres alvarez commented

Thanks for the clarification. That makes sense.
My concern was mainly about the feature parity between 2.x and 3.x, specifically the automatic refresh that exists in 2.x but not in 3.x.

I understand now that 3.x is focused on Drupal 11 support and that the other fixes will be ported later as the related tickets are resolved.

I'll keep an eye on the other tickets and the future ports to 3.x.