I have a suggestion for how its implemented, move the menus from /arrange-fields/NODETYPE to a tab within the content type edit, like /admin/content/types/NODETYPE/arrange-fields. This would be more consistent with what people are used to, and would keep the configuration workflow in the same place.

I've also found what I think its a bug, though not sure if its a known bug. I attach a screenshot for it, but basicaly fieldsets that are collapsible do not behave normaly when this module is taking control of their display, meaning they do not push down/up the content below when expanded/collapsed. This at the moment would render the module unuseable for any user having access to such fieldsets, so Im setting the priority to critical.

Besides this, I think it's a very promising module =)

Comments

manuel garcia’s picture

StatusFileSize
new8.47 KB
richardp’s picture

That's interesting about the fieldset. It cannot push down the content normally (or at least, I cannot figure out how to make it do that) because all of the elements have been given absolute positions. But what is *supposed* to happen is the z-index of the opened fieldset goes up, so the opened fieldset should cover up anything behind it, until it is closed. At least, that is what it does for me. What browser & version are you using?

Good point about the menu hook. I will see what I can do about that.

richardp’s picture

Eek! Never mind-- I just noticed that indeed, the fieldsets are no longer working for me either. How annoying. I will get that (and the menu) fixed, then put it out as a new alpha release.

Thanks for your help!

richardp’s picture

Version: 6.x-1.0-alpha2 » 6.x-1.0-alpha3
Status: Active » Fixed

Well, it turned out to be a very easy fix. I was using jquery to target fieldsets, and I had a typo in the jquery selector string. I must have introduced the typo when I was getting the module ready to put on drupal.org.

Thanks for pointing it out for me! Hopefully that's the last one for a while. I put out a new release as alpha3, since that little bug made alpha2 somewhat unusable.

I also went ahead and made those menu hook changes.

manuel garcia’s picture

great, glad to help richardp!

I bet we'll find more things like this though (not typos), the node form is a BEAST and a lot of things can happen in there hehe. Plus the module allows for very imaginative layouts, so who knows.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

pepemty’s picture

Version: 6.x-1.0-alpha3 » 6.x-1.x-dev

Probably the typo found it's way back... ;-)
I'm using dev (2010-Jul-21), and have the described problem with the fieldsets.
Any suggestion?

Great module, btw.

richardp’s picture

Priority: Critical » Normal

Hehe :) Well, you might be talking about something which isn't really a bug...

What is *supposed* to happen is indeed, the fieldsets do not "push down" the other content on the page. Because they have been positioned with CSS, they've been taken out of the normal document flow, and won't push down the items below them which have also been positioned with CSS. I don't know of any way to make them behave the old way w/o some major jquery dependency (which I would like to steer away from, in case the web visitor has javascript disabled, or is on a simple web browser, like on a cell phone, and has no javascript).

What I tried to do to compensate for this is that when you click them, their z-index goes up, so the one you clicked on will be in the foreground.

As a result, if you are using collapsible fieldsets in your form, you need to position them in such a way that they will remain visible when opened (like putting them side-by-side). I know this is kind of a janky way to do it. One alternative would be to install Vertical Tabs, which transforms your fieldsets into, well, vertical tabs. The module shouldn't have any problem positioning that. You could also try to disable the collapsing behavior, and have them open all the time.

In my earlier post, I had found a typo, and this z-indexing behavior wasn't working. I just checked my local copy, and it is still working for me. Is that what you meant, or did you mean that it wasn't "pushing down" the content?

(If it's that it isn't pushing down the content, I'm sorry, that really is the way its supposed to work. Now, I would love to make it actually push down all the content under it, just like the old way. If anyone out there in Internet Land has some ideas, please post here or in a new issue)

And if you mean the z-indexing isn't working-- sorry for the long preamble-- what browser and version are you using?

Thanks for taking an interest in the module!
Richard

pepemty’s picture

Personally I use the latest version of Firefox (naturally), although my users rely mostly on IE... :-(

And yes, at least I guess, my issue has to do with the z-index since the drop-down text overlaps the following options --which btw are the regular Drupal node options (menu, authoring, publishing, attach file, revisions, etc).

Thanks for the prompt reply. ;-)

Warm regards from way too sunny México!
:-)
José

richardp’s picture

StatusFileSize
new3.35 KB
new3.23 KB

I see. I just set up a new test instance of drupal, containing no additional modules than arrange_fields (the current dev release) and jquery_ui.

I am attaching two screenshots. They are of 2 fieldsets which I have positioned near each other. In the first image, I have clicked on the body of one, and it is in the foreground, and in the second, I have clicked on the other one, so it is in the foreground.

I take it you are not seeing this behavior? Try clearing your browser's cache and your drupal cache, to remove any potentially faulty javascript.

If the problem is still happening, could you attach a screenshot demonstrating what's going on?

Thanks!
Richard

PS: I live in Louisiana, USA, and it's been fairly horribly hot-- around 105 F. I can only imagine what Mexico must be like right now!

pepemty’s picture

StatusFileSize
new92.5 KB
new51.54 KB

Drupal and browser's cache cleared as suggested... problem remains... :-(

I'm sending you a couple of screen shots. The first one just shows the pile-up of fieldsets I made with Arrange Fields.
The second shows how the drop-downs get in each others way... hehe

Thanks again for your prompt reply... :-)
Best regards.
José

ps.- Louisiana? You sure know what hot and humid is! Pretty much what we get here from March to late October... :-(

richardp’s picture

Okay-- I think I know what you need to do, and I think it's simple-- just make your fieldsets have a solid background color. Edit your theme's CSS file, and add in the appropriate style... possibly:

fieldset {
background-color: white;
}

You might have to be more specific with the css though.

My theory is that your fieldsets are indeed getting their Z-indexes updated, but since their backgrounds are transparent, they still look funky.

Give it a try and see if that looks better.

Thanks,
Richard

pepemty’s picture

Thanks Richard!
That did the trick, just had to find exactly which fieldset class was involved, so others wouldn't be messed up... ;-)
(Firebug is our friend!)

Warm regards!
José