There are some instances where the title field coming from ArchivesSpace has markup in it. We currently use a string which escapes markup. We should be able to support transforming the emph element into an em tag on ingest so it formats properly. We normally couldn't do anything for the display string value, but the html_title module (which we can include in composer as a recommended module) can help there.
We need to update the provided configs and write an update hook to copy existing data from existing 'field_as_title' string-based fields into a new text-based field, as well as any form or display mode configs.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3183084-5.patch | 3.8 KB | Pooja Ganjage |
| #2 | 3183084-2.patch | 1.18 KB | Pooja Ganjage |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
Pooja Ganjage commentedHi,
Creating a patch for changing a title field type.
Please review the patch.
Let me know if any suggestions.
Thanks.
Comment #3
Pooja Ganjage commentedComment #4
seth.e.shaw commentedPooja, thanks for that, although there are several other spots where we need to update the defaults. Also, I'm working on an update hook that will update existing field_as_title fields to use the new field type. There is an issue fork but I haven't committed my work thus-far as I was still working on that hook.
Comment #5
Pooja Ganjage commentedUpdated patch.
Comment #6
seth.e.shaw commentedPooja, as you can see by the issue fork, I'm also trying to get an update hook for this. I still need it to preserve the existing form and view mode settings... but I'm working on it.
Comment #7
seth.e.shaw commentedI've updated the issue fork so that it preserves display modes. I think it is ready to go, but could probably use a larger test before merge.
Comment #10
seth.e.shaw commentedComment #11
seth.e.shaw commentedReopened because we didn't update the migrations that pull in the data for this field. We also should filter display_strings for emph tags.
Comment #13
seth.e.shaw commented