If no demographic data was configured the foreach loop would print a PHP

Warning: Invalid argument supplied for foreach() in _apsis_mail_submit()

On PHP 7.2 we will also run into a PHP warning when no demographic data is set:

Warning: count(): Parameter must be an array or an object that implements Countable in Drupal\apsis_mail\Form\SubscribeForm->buildForm() (line 77 of modules/contrib/apsis_mail/src/Form/SubscribeForm.php).
CommentFileSizeAuthor
#5 apsis_mail-avoid-php-warning-3014923-5.patch2.42 KBarnested
#4 apsis_mail-avoid-php-warning-3014923-4.patch1.9 KBarnested
#3 apsis_mail-avoid-php-warning-3014923-3.patch1.9 KBarnested
#2 apsis_mail-avoid-php-warning-3014923-2.patch1.28 KBarnested

Comments

arnested created an issue. See original summary.

arnested’s picture

arnested commented
Status: Active » Needs review
StatusFileSize
new apsis_mail-avoid-php-warning-3014923-2.patch1.28 KB
arnested’s picture

arnested commented
Priority: Normal » Major
Issue summary: View changes
StatusFileSize
new apsis_mail-avoid-php-warning-3014923-3.patch1.9 KB

On PHP 7.2 we will also run into a PHP warning when no demographic data is set. Raising priority to major.

arnested’s picture

arnested commented
StatusFileSize
new apsis_mail-avoid-php-warning-3014923-4.patch1.9 KB
arnested’s picture

arnested commented
StatusFileSize
new apsis_mail-avoid-php-warning-3014923-5.patch2.42 KB

  • Xen committed 275dfd1 on 8.x-2.x authored by arnested 
    Issue #3014923 by arnested: Avoid warning if no demograpich data is...
xen’s picture

xen commented
Status: Needs review » Fixed

Was already partially done, I've added the last fixes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.