Request getting data from apsis contains no caching. This results in a request to the Apsis API each time a page is loaded, that contains eg. the signup block.

I suggest adding cache, both static and using the cache backend.

CommentFileSizeAuthor
#4 get_requests_not_cached-2816733-4.patch2.62 KBmian3010
#3 get_requests_not_cached-2816733-3.patch3.37 KBkasperg
#2 get_requests_not_cached-2816733-2.patch5.76 KBmian3010

Comments

mian3010 created an issue. See original summary.

mian3010’s picture

mian3010 commented
StatusFileSize
new get_requests_not_cached-2816733-2.patch5.76 KB

Attached proposed solution

kasperg’s picture

kasperg commented
StatusFileSize
new get_requests_not_cached-2816733-3.patch3.37 KB

Here is an updated version of the change.

Instead of adding cache logic into the individual methods we instead use a wrapper around the request method.

mian3010’s picture

mian3010 commented
StatusFileSize
new get_requests_not_cached-2816733-4.patch2.62 KB

It seems that it is a bad idea to cache getSubscriberMailingLists, as when a user removes subscription, the display would not update until cache had expired.

  • Snipon committed 16f106f on 8.x-1.x 
    Issue #2816733 by mian3010 and kasperg: Get requests not cached.
Snipon’s picture

Snipon commented
Status: Active » Fixed
Snipon’s picture

Snipon commented
Status: Fixed » Closed (fixed)