Having write access to sites is not optimal or practical in most situations. Apps should use filetransfer authorized like the update module.

CommentFileSizeAuthor
#6 1348732-11-apps-file-transfer.patch1.71 KBrandallknutson
#1 apps_authorize_1348732.patch3.42 KBrandallknutson

Comments

randallknutson’s picture

randallknutson commented
Status: Active » Needs review
StatusFileSize
new apps_authorize_1348732.patch3.42 KB

I'm not 100% sure which part of this patch fixed this but it seems to work for me now on all the apps I've tried.

randallknutson’s picture

randallknutson commented

After further testing I figured out it was removing
unset($_SESSION['update_manager_update_projects']);
that made the difference. The rest of the cleanup is nice though.

tomdavidson’s picture

tomdavidson commented

Exciting. Does this patch solve issues such as OpenPublic's Apps wanting write access to sites but Aegir not liking such? If so, my itch maybe getting scratched.

Do you want me to test patch in #1, or do you have an update?

best, tom

e2thex’s picture

e2thex commented

When you were testing did you have both SSH and FTP or just FTP?

randallknutson’s picture

randallknutson commented

When I was testing I used SSH.

randallknutson’s picture

randallknutson commented
StatusFileSize
new 1348732-11-apps-file-transfer.patch1.71 KB

My original patch had some cruft in it from some other stuff I was working on. This one has the same changes without the extra stuff. I've tested it with SSH and it works great.

e2thex’s picture

e2thex commented
Issue tags: +sprint candidate

tagging for sprint

e2thex’s picture

e2thex commented
Status: Needs review » Fixed

commit http://drupalcode.org/project/apps.git/commit/ef3294a

thank you very much

Automatically closed -- issue fixed for 2 weeks with no activity.