api_orchestrator 1.1.4

API Orchestrator 1.1.4

Drupal.org code review compliance release — addresses all five review feedback points for modern Drupal 10.3+/11 best practices.

OOP Hook Implementations

• Converted all procedural hooks to class-based implementations using #[Hook] PHP attributes across 9 modules
• All .module files are now empty stubs — hook logic lives in src/Hook/ classes with autowired dependency injection
• Replaced all \Drupal::service() calls in hook code with constructor-injected dependencies

PHP Attributes (Annotations Removed)

• Replaced @ContentEntityType, @ConfigEntityType, @QueueWorker annotations with PHP 8.1+ attributes across 6 entity/plugin classes
• Converted 4 @NotificationProvider plugin annotations to attributes; created new Attribute\NotificationProvider class for custom plugin type discovery
• All @Translation() replaced with new TranslatableMarkup(), string class references replaced with ::class syntax

Constructor Property Promotion

• Converted 13 controllers and forms to use PHP 8.1+ constructor property promotion
• Removed separate property declarations and constructor body assignments
• Properly handled parent class property conflicts (entityTypeManager, configFactory, messenger) with non-promoted assignment pattern

ConfigFormBase #config_target

• Replaced all #default_value with #config_target in ApiOrchestratorSettingsForm
• Removed manual submitForm() config save — parent ConfigFormBase handles it automatically
• Custom validateForm() for API token validation preserved

Composer

• Removed drupal/core from require — Drupal.org Composer façade handles core version constraint

ESLint (Zero Warnings)

• Fixed all 297 ESLint warnings across 7 JS files (request detail, analytics, monitoring, export, mirror config/listing, reports)
• Named all anonymous functions (func-names), added JSDoc @param tags, fixed Drupal~behavior type syntax
• Refactored deeply nested callbacks, removed unused variables, replaced i++ with i += 1

Additional Fixes

• Fixed PHPStan readonly property double-assignment in NotificationProvider attribute
• Fixed YAML prettier formatting in Magento, Shopify, and JSONPlaceholder sample config files
• Restored JS files corrupted by accidental phpcbf run on non-PHP files

Notes

• No API or functionality changes — this is a code standards and review compliance release
• All 122 unit tests passing (284 assertions)
• All CI checks clean: ESLint (0 errors, 0 warnings), Stylelint (0), PHPStan (0), PHPCS (0)
• Upgrade from 1.1.3 recommended

Feedback and issue reports welcome at the issue queue.