Problem/Motivation

Drupal has the ability to return translated content for simple use cases. The ApiClient should be able to fetch localized content.

Steps to reproduce

Proposed resolution

- The client accepts a defaultLocale that is used for all requests by default unless a locale is given
- The retrieval methods accept a locale that overrides the default if it exists

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork api_client-3377803

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

coby.sher created an issue. See original summary.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: Unassigned » pratik_kamble

pratik_kamble opened merge request !11

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: pratik_kamble » Unassigned
Status: Active » Needs review
coby.sher’s picture

coby.sher commented
Assigned: Unassigned » coby.sher

Starting review on this one

coby.sher’s picture

coby.sher commented
Assigned: coby.sher » Unassigned
Status: Needs review » Needs work
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: Unassigned » pratik_kamble
Status: Needs work » Active
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: pratik_kamble » Unassigned
Status: Active » Needs review
coby.sher’s picture

coby.sher commented
Assigned: Unassigned » coby.sher
Status: Needs review » Reviewed & tested by the community
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented

May be for future PRs. I was wondering what is best way to showcase this examples? Should we create another page in examples? @brianperry would love to hear your thought on it.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: coby.sher » pratik_kamble
Status: Reviewed & tested by the community » Active
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: pratik_kamble » Unassigned
Status: Active » Needs review
coby.sher’s picture

coby.sher commented
Status: Needs review » Reviewed & tested by the community
brianperry’s picture

brianperry
he/him
commented
Status: Reviewed & tested by the community » Needs work

Setting to needs work based on recent review.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: Unassigned » pratik_kamble
Status: Needs work » Active
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: pratik_kamble » Unassigned
Status: Active » Needs review

brianperry’s picture

brianperry
he/him
commented
Status: Needs review » Fixed

Merged. Marking as fixed. Thanks @pratik_kamble and @CobyPear!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.