Warning: Invalid argument supplied for foreach() in user_permission_get_modules() (line 3037 of modules/user/user.module).

This warning is thrown because annotator_permission() doesn't return an array as expected. The full content of this function is commented out, so the whole function may as well be removed: that's what we have version control for.

Looks like the permissions that were here have been moved to the Annotation module, but they are still checked here in Annotator. Should this module depend on Annotation?

Comments

BrockBoland’s picture

BrockBoland commented

Can Annotator be used without Annotation? I think it can, in theory, but one would have to write JS to make it happen…I think. Without Annotation enabled, the 'administer annotations' permission isn't available, so one wouldn't be able to change the Store plugin options at /admin/config/content/annotator anyway (well, unless logged in as uid 1, but that's an edge case).

I think that Annotator should list Annotation as a dependency.