Attached is a patch which adds a hook_menu and a settings callback to configure three things:

- CharsetMethod
- Charsetphp
- Charsetsql

The $gateway->setCharsetHandler hardcode values are replaced by variable_get() functions.
This way, we don't need to fiddle with the files and it's easier to configure and test.

I'm using a select box now, I guess we should add more options ? Or maybe just use a textfield.

CommentFileSizeAuthor
settings.patch2.19 KBswentel

Comments

jody lynn’s picture

jody lynn
she/her
Primary language English
commented

Related duplicate: #167376: Gateway Charsethandler overridden

snelson’s picture

snelson commented
Status: Active » Fixed

I like this ...

I've modified this a bit to add the settings page at: admin/build/services/settings/amfphp, which should be the convention for other server settings pages, and have committed to both D5 and D6 branches.

Thanks,
Scott

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.