First - Thank you for this nice module and your good stuff!
I tried the cvs version and get a blank page if I want import a new item. I look a little bit in the code and found the part in the function amazon_import_page(). Original code is

return form($search_form).form($output).$_search_pager;

I changed this to:

print theme('page', form($search_form).form($output).$_search_pager);

Now the import function work on my drupal 4.6.3 fine.

I want use the module on a german website (http://segeln.veb-ts.de) - and I think the module should all strings wrap in the t-function for translation (e.g. price and binding and so on). Can we do this stuff? I will help you at this work if you want - please contact me.

Thomas

CommentFileSizeAuthor
#2 AMAZONTOOLS_4-6_HACK.txt5.72 KBPrometheus6

Comments

Prometheus6’s picture

Version: master » 4.6.x-1.x-dev
Assigned: Unassigned » Prometheus6

I'm not ignoring you. I did miss some of the text that should be translateable. There's some things I need to do in the cvs version though, and changes will be for 4.7, not 4.6.0.

I've decided to deal with this like a bug fix for 4.6, and since you brought it to my attention, I'll work on making the cvs version properly translateable before I try the new form API stuff. I'll email you via the contact form when it's done, but before I post any form api changes.

Understand that you'll have a unique version of the code. The differences between what you'll have and the 4.6 and 4.7 versions are small but significant. And it will take a couple more days to get to it (though nothing stops you from starting on it if you like; look for the theme, search and form functions).

Prometheus6’s picture

StatusFileSize
new5.72 KB

I think I made all the displayed strings translatable. But I also started work on the Form API conversion. This means you can't just modify the HEAD version to work with 4.6 as you did anymore.

Because you brought it to my attention and it's no extra work for me, I'm attaching just the routines that needed changing...you can cut and paste them to make your particular version fully translatable.

Prometheus6’s picture

Status: Active » Closed (fixed)